hoo2/InformationSystemsSecurity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SQL injection in login using prepared statements

Browse Source
This commit is contained in:
Christos Choutouridis 2026-01-10 22:31:10 +02:00
parent 6a2ca8f2a4
commit 75f47a76b0
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
passman-dev/php/passman/login.php
View File

@ -26,16 +26,21 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
// }
require_once __DIR__ . "/config.php";
// xxx' OR 1=1; -- '
$sql_query = "SELECT * FROM login_users WHERE username='{$username}' AND password='{$password}';";
//echo $sql_query;
// Use a prepared statement to prevent SQL injection.
$stmt = $conn->prepare("SELECT id FROM login_users WHERE username = ? AND password = ?");
// Check if the credentials are valid
$result = $conn->query($sql_query);
if ($stmt === false) {
// Fail closed (do not leak details in production).
die("Prepare failed.");
}
$stmt->bind_param("ss", $username, $password);
$stmt->execute();
$stmt->store_result(); // Needed to use $stmt->num_rows
unset($_POST['username']);
unset($_POST['password']);
if (!empty($result) && $result->num_rows >= 1) {
if ($stmt->num_rows >= 1) {
// Regenerate session ID to prevent session fixation!
//session_regenerate_id(true);
@ -48,8 +53,8 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
// $_SESSION['user_id'] = $row['id'];
//}
// Free result set
$result -> free_result();
// Close
$stmt->close();
$conn -> close();
// Redirect to a dashboard page
@ -58,7 +63,7 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
} else {
$login_message = "Invalid username or password";
}
$stmt->close();
$conn -> close();
}
}